V15: umb-dropzone extends umb-input-dropzone#18784
Merged
leekelleher merged 18 commits intov15/devfrom Mar 25, 2025
Merged
Conversation
moves the umb-dropzone back into the media package and extends the umb-input-dropzone for common logic
1 task
leekelleher
approved these changes
Mar 25, 2025
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
Tested out, all working as expected! 🚀
This was referenced Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a lot of shared logic between umb-dropzone and umb-input-dropzone and this makes sure common logic is shared by extending umb-input-dropzone.
This is part of the preparation to ensure umb-input-dropzone only handles temporary files and umb-dropzone only handles media items. Therefore the
createAsTemporaryon umb-dropzone has been marked as deprecated and a new UmbDropzoneMediaManager, which currently does not do much, has been created.How to test