Skip to content

Fixed typo in TinyMCE's da.js#18628

Merged
mikecp merged 1 commit intoumbraco:v13/devfrom
abjerner:patch-2
Mar 10, 2025
Merged

Fixed typo in TinyMCE's da.js#18628
mikecp merged 1 commit intoumbraco:v13/devfrom
abjerner:patch-2

Conversation

@abjerner
Copy link
Copy Markdown
Contributor

Not a lot to describe here. In TinyMCE in Umbraco 13, the Clear formatting label is spelled with two t's in Danish, where it only should be one (formatering instead of formattering).

image

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2025

Hi there @abjerner, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Copy Markdown
Contributor

mikecp commented Mar 10, 2025

Hi @abjerner,

Thank you for spotting the typo and providing the fix 👍😉

Not a lot to do except approve and merge it 😁

Cheers!

@mikecp mikecp enabled auto-merge (rebase) March 10, 2025 14:22
@mikecp mikecp merged commit d3b6027 into umbraco:v13/dev Mar 10, 2025
20 checks passed
@abjerner abjerner deleted the patch-2 branch March 11, 2025 08:45
@AndyButland
Copy link
Copy Markdown
Contributor

Just a quick update on this for Umbraco 15 - I don't think we can bring it over, as TinyMCE is coming in as a node_module now. For 13, although it's still an external library, we've got the source as part of Umbraco so can make the update you've done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants