Fix issue text overflow when user name is too long#18587
Fix issue text overflow when user name is too long#18587iOvergaard merged 12 commits intov15/devfrom
Conversation
|
That's a pretty long name 😅 I think it would be better to hide overflow using ellipsis. or line clamp specific 2 lines which is supported in most modern browsers: https://caniuse.com/?search=line-clamp |
… v15/fix-bug/username-overflow
|
Thanks @bjarnef , I have changed my PR, we will display the user name with ellipsis at the end and when hovering, the user can see the full text. |
# Conflicts: # tests/Umbraco.Tests.AcceptanceTest/package-lock.json # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeDesignTab.spec.ts
leekelleher
left a comment
There was a problem hiding this comment.
Resolved the merge conflict and tested out, looking good! 🚀
....UI.Client/src/packages/user/user/collection/views/grid/user-grid-collection-view.element.ts
Outdated
Show resolved
Hide resolved
....UI.Client/src/packages/user/user/collection/views/grid/user-grid-collection-view.element.ts
Outdated
Show resolved
Hide resolved
nielslyngsoe
left a comment
There was a problem hiding this comment.
I have added a few comments :-)
|
I now see that we have the user-name in the Making the 'not logged in yet'-message the replacement for the missing date. In similar manner we do not render the name when the user has logged in. And with umbraco/Umbraco.UI#1036 then the card seems good. Then I would actually revert the ellipsis from the date part here — we know the length of this message, no need to hide it. |
....UI.Client/src/packages/user/user/collection/views/grid/user-grid-collection-view.element.ts
Outdated
Show resolved
Hide resolved
....UI.Client/src/packages/user/user/collection/views/grid/user-grid-collection-view.element.ts
Outdated
Show resolved
Hide resolved
+ other code formatting tweaks.
iOvergaard
left a comment
There was a problem hiding this comment.
Added a fallback key and <umb-localize />. LGTM.

Prerequisites
If there's an existing issue for this PR then this fixes
Description
This PR fixes the issue #18535
After fixed:
