V15: Adds migration of data type configuration when changing property editor UI#18534
Merged
leekelleher merged 5 commits intov15/devfrom Mar 3, 2025
Merged
Conversation
…e property editor ui to another this is really useful when migrating from tinymce to tiptap for example
leekelleher
approved these changes
Mar 3, 2025
Member
leekelleher
left a comment
There was a problem hiding this comment.
Tested it out TinyMCE to Tiptap, and also between other compatible property-editors, e.g. Checkbox List to Radiobutton List (and others with the "items" configuration field); the numeric editors (Decimal and Integer). All working well. 🚀
This was referenced Sep 28, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to the
UmbDataTypeWorkspaceContextclass and updates to the acceptance tests for data types. The main focus is on improving the handling of default data and ensuring that configurations are transferred correctly.It adds a comparer that keeps useful data around when migrating from one property editor ui to another. Currently, it compares based on the alias, so if it's the same, it will keep the data. This is similar behavior to V13. I added a TODO to potentially find the schema alias and compare based on that, but we currently do not have that available at that point in the code.
This is useful when migrating from tinymce to tiptap, for example, but also Number -> Decimal, Text Area -> Text Box, and other similar data types.
Changes to data type handling:
src/Umbraco.Web.UI.Client/src/packages/data-type/workspace/data-type-workspace.context.ts: Updated theUmbDataTypeWorkspaceContextclass to properly transfer default data from the schema and UI while preserving existing data that is not in the default data.Updates to acceptance tests:
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataType.spec.ts: Added amaxCharsparameter to thecreateTextstringDataTypemethod and included a test to verify that themaxCharssetting is correctly transferred and stored. [1] [2]How to test