Skip to content

V15: Adds migration of data type configuration when changing property editor UI#18534

Merged
leekelleher merged 5 commits intov15/devfrom
v15/feature/migrate-data-type-config
Mar 3, 2025
Merged

V15: Adds migration of data type configuration when changing property editor UI#18534
leekelleher merged 5 commits intov15/devfrom
v15/feature/migrate-data-type-config

Conversation

@iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Mar 3, 2025

Description

This pull request includes changes to the UmbDataTypeWorkspaceContext class and updates to the acceptance tests for data types. The main focus is on improving the handling of default data and ensuring that configurations are transferred correctly.

It adds a comparer that keeps useful data around when migrating from one property editor ui to another. Currently, it compares based on the alias, so if it's the same, it will keep the data. This is similar behavior to V13. I added a TODO to potentially find the schema alias and compare based on that, but we currently do not have that available at that point in the code.

This is useful when migrating from tinymce to tiptap, for example, but also Number -> Decimal, Text Area -> Text Box, and other similar data types.

Changes to data type handling:

Updates to acceptance tests:

How to test

  1. Set up a data type with TinyMCE as the editor ui
  2. Click "Change" and switch to Tiptap
  3. Check that all comparable configuration data is transferred/migrated, for example that blocks are still configured

…e property editor ui to another

this is really useful when migrating from tinymce to tiptap for example
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out TinyMCE to Tiptap, and also between other compatible property-editors, e.g. Checkbox List to Radiobutton List (and others with the "items" configuration field); the numeric editors (Decimal and Integer). All working well. 🚀

@leekelleher leekelleher enabled auto-merge (squash) March 3, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants