Merged
Conversation
…/Stylesheet package
as it may be used in 3rd party extensions. TinyMCE will be removed in v16, but this deprecation notice in 15.4 will at least notify that the "Umb.PropertyEditorUi.StylesheetPicker" UI can be used.
+ UI tweaks
uses `@open` event for UI consistency with other pickers.
Moves "StarterKit" styles to the RTE Essentials extension registration. Scopes TinyMCE in "rte-content.css" (for now).
bjarnef
reviewed
Feb 28, 2025
...roperty-editors/stylesheets/property-editor-ui-tiny-mce-stylesheets-configuration.element.ts
Show resolved
Hide resolved
iOvergaard
approved these changes
Feb 28, 2025
This was referenced Sep 28, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Stylesheet configuration to the Tiptap RTE.
The Stylesheet picker property-editor that is used for the TinyMCE configuration was scoped to the
tinymcepackage, so I've moved (duplicated) the code to add the property-editor to thetemplating/stylesheetspackage. I've updated thepropertyEditorUiAliasfor TinyMCE, so the upcoming community package can reference Umbraco's stylesheet picker.There are some additional tweaks in this PR whilst I was in the Stylesheet section.
How to test?
Best to test against the server, as the mock-server doesn't have the capability to serve the Stylesheet contents as a static-file (yet). Add a stylesheet (new or existing) to the Tiptap RTE configuration, view the RTE on a document... check that the styles have loaded.
Here's an example CSS that would be visually obvious if it's loaded or not.