Skip to content

Fixes the Fatal icon text so it's readable in Dark Mode.#18375

Merged
nielslyngsoe merged 1 commit intoumbraco:contribfrom
readingdancer:v15/bugfix/fix-log-viewer-level-tag-fatal-text-color
Feb 18, 2025
Merged

Fixes the Fatal icon text so it's readable in Dark Mode.#18375
nielslyngsoe merged 1 commit intoumbraco:contribfrom
readingdancer:v15/bugfix/fix-log-viewer-level-tag-fatal-text-color

Conversation

@readingdancer
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Issue 18374

Description

  • Open up Umbraco 15
  • Navigate to Settings
  • Navigate to Log Viewer
  • Open one of the detailed logs, like "All"
  • Change your Umbraco settings to use "Dark Mode"

If you are using the client project, you should see a "Fatal" error icon and the text is too dark to be able to read, dark grey on black.

This PR fixes that :)

@github-actions
Copy link

Hi there @readingdancer, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) February 18, 2025 20:59
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks for the attention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants