Skip to content

V15 QA complex block grid test#18347

Merged
andr317c merged 9 commits intov15/devfrom
v15/QA/complex-block-grid-test
May 8, 2025
Merged

V15 QA complex block grid test#18347
andr317c merged 9 commits intov15/devfrom
v15/QA/complex-block-grid-test

Conversation

@andr317c
Copy link
Copy Markdown
Contributor

No description provided.

@andr317c andr317c marked this pull request as ready for review May 1, 2025 14:13
Copilot AI review requested due to automatic review settings May 1, 2025 14:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new acceptance test to validate the complex block grid functionality including error handling when property values do not match expected formats and subsequently verifying correct updates.

  • Introduces a comprehensive test scenario simulating document type creation, block grid setup, and UI interactions.
  • Validates error notifications for invalid inputs and confirms successful content publication after corrective actions.
Comments suppressed due to low confidence (1)

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ComplexBlockGridTest.spec.ts:1

  • [nitpick] The file appears to start with a non-visible Unicode BOM character. Consider ensuring that the file encoding is intentional to avoid potential issues in different environments.
import {expect} from '@playwright/test';

Copy link
Copy Markdown
Contributor

@nhudinh0309 nhudinh0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some comments and the test is currently failing - need to fix it.

Copy link
Copy Markdown
Contributor

@nhudinh0309 nhudinh0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andr317c andr317c merged commit 2754780 into v15/dev May 8, 2025
21 checks passed
@andr317c andr317c deleted the v15/QA/complex-block-grid-test branch May 8, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants