Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new acceptance test to validate the complex block grid functionality including error handling when property values do not match expected formats and subsequently verifying correct updates.
- Introduces a comprehensive test scenario simulating document type creation, block grid setup, and UI interactions.
- Validates error notifications for invalid inputs and confirms successful content publication after corrective actions.
Comments suppressed due to low confidence (1)
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ComplexBlockGridTest.spec.ts:1
- [nitpick] The file appears to start with a non-visible Unicode BOM character. Consider ensuring that the file encoding is intentional to avoid potential issues in different environments.
import {expect} from '@playwright/test';
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ComplexBlockGridTest.spec.ts
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ComplexBlockGridTest.spec.ts
Show resolved
Hide resolved
nhudinh0309
requested changes
May 5, 2025
Contributor
nhudinh0309
left a comment
There was a problem hiding this comment.
Had some comments and the test is currently failing - need to fix it.
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ComplexBlockGridTest.spec.ts
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ComplexBlockGridTest.spec.ts
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ComplexBlockGridTest.spec.ts
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ComplexBlockGridTest.spec.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.