Skip to content

V15: Save the variant before scheduling#18344

Merged
iOvergaard merged 22 commits intov15/devfrom
v15/feature/schedule-save
Feb 17, 2025
Merged

V15: Save the variant before scheduling#18344
iOvergaard merged 22 commits intov15/devfrom
v15/feature/schedule-save

Conversation

@iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Feb 14, 2025

Description

Fixes AB#49138
Fixes AB#49144

To bring feature parity from V13 to V15, this feature allows the workspace to save the latest version of the document before scheduling. This also means that we will now be running validation before scheduling:

2025-02-14.at.16.03.09.-.Coral.Salamander.mp4

Another change is that each calling function is now responsible for showing the appropriate notifications. This brings about a bit of duplication but allows for much more fine-grained control of what to show to the user.

The V13 Backoffice had some interesting speech bubbles when publishing with a lot of information within. I have tried (for now) to reuse the same texts, but I am not convinced this gives the best experience to the user, but let me know what you think.

image

Lastly, started using variables for bulk publishing again, where it shows how many documents and languages were published:

2 documents and 2 languages
image

Caveat

  • I cannot find the name of the language of the variant to show in the speech bubble as was done in V13. This requires a bit of lookup and to spin up the language repository.
  • If you publish a page with no variants, the speech bubble looks a bit off:
    image

# Conflicts:
#	src/Umbraco.Web.UI.Client/src/libs/localization-api/localization.controller.test.ts
#	src/Umbraco.Web.UI.Client/src/libs/localization-api/localization.controller.ts
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, functionality is works as expected, all good.

I agree the localizations for the various scenarios are odd. I suspect we need to do a general review & tidy-up of the messaging.

But let's merge this in, as feature wise it's an improvement (and feature parity). 🚀

@leekelleher leekelleher enabled auto-merge (squash) February 17, 2025 14:23
@iOvergaard iOvergaard disabled auto-merge February 17, 2025 15:03
@iOvergaard iOvergaard enabled auto-merge (squash) February 17, 2025 15:04
@iOvergaard iOvergaard merged commit ed63f27 into v15/dev Feb 17, 2025
22 of 23 checks passed
@iOvergaard iOvergaard deleted the v15/feature/schedule-save branch February 17, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments