Skip to content

V15: Add a button to clear schedule#18339

Merged
leekelleher merged 9 commits intov15/devfrom
v15/feature/schedule-remove
Feb 17, 2025
Merged

V15: Add a button to clear schedule#18339
leekelleher merged 9 commits intov15/devfrom
v15/feature/schedule-remove

Conversation

@iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Feb 14, 2025

Description

Fixes AB#45942

  • Adds a button to clear a set schedule.
  • Adds a text if a schedule has changed.
  • Removes an unused old body for emails of scheduled content

image

How to test

  1. Schedule a document and try to set a schedule
  2. Try to clear the schedule
  3. Test that the text does not show up unless there are changes

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, all good, except that I noticed if a document has existing scheduled publish/unpublish dates, then the remove button doesn't appear. I've added commit 4f4183a to fix that. 👍

@leekelleher leekelleher enabled auto-merge (squash) February 17, 2025 10:16
@leekelleher
Copy link
Member

One thing to mention, with the refactor of the <umb-input-date> component, I'm wondering whether we need that component anymore? As the uses within the CMS can be resolved by using <uui-input> directly. Of course, we would deprecate it first. 😀

@iOvergaard
Copy link
Contributor Author

One thing to mention, with the refactor of the <umb-input-date> component, I'm wondering whether we need that component anymore? As the uses within the CMS can be resolved by using <uui-input> directly. Of course, we would deprecate it first. 😀

We should not throw it away just yet. It sets a standard and overrides what types you are allowed to define. Also, it more easily allows you to target date-specific inputs.

A consideration I had was to keep the internal uui-input and add the appended Clear-button in the component directly instead. That would give a more unified look wherever the component is used. It wouldn't allow you to specify slots from the outside, but if you needed that, you could use the uui-input directly. What do you think about that?

@leekelleher leekelleher merged commit 89d4563 into v15/dev Feb 17, 2025
22 of 23 checks passed
@leekelleher leekelleher deleted the v15/feature/schedule-remove branch February 17, 2025 10:48
@leekelleher
Copy link
Member

A consideration I had was to keep the internal uui-input and add the appended Clear-button in the component directly instead. That would give a more unified look wherever the component is used. It wouldn't allow you to specify slots from the outside, but if you needed that, you could use the uui-input directly. What do you think about that?

I'd be happy with this approach. Gives a consistent experience for date/time inputs. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments