Skip to content

Code review: Removing AsSpan, the List for overhead is negligible

2bd49c0
Select commit
Loading
Failed to load commit list.
Merged

Avoid allocating strings for parsing comma separated int values #18199

Code review: Removing AsSpan, the List for overhead is negligible
2bd49c0
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (contrib) failed Apr 7, 2025 in 41s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Code Duplication)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
StringExtensionsBenchmarks.cs 1 advisory rule 10.00 → 9.10 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication StringExtensionsBenchmarks.cs

Annotations

Check warning on line 44 in tests/Umbraco.Tests.Benchmarks/StringExtensionsBenchmarks.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

❌ New issue: Code Duplication

The module contains 8 functions with similar structure: Linq,SplitToHeapStrings,SplitToStackSpansWithEmptyCheck,SplitToStackSpansWithEmptyCheck and 4 more functions. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.