V16: Allow MaxRequestLength to be specified as a long#18141
Merged
iOvergaard merged 4 commits intov16/devfrom Jan 29, 2025
Merged
V16: Allow MaxRequestLength to be specified as a long#18141iOvergaard merged 4 commits intov16/devfrom
MaxRequestLength to be specified as a long#18141iOvergaard merged 4 commits intov16/devfrom
Conversation
… to be able to accept larger files the underlying kestrel architecture already accepts a `long` in ConfigureKestrelServerOptions.cs
Contributor
|
Looks like this contains some unexpected additional updates @iOvergaard. |
Contributor
Author
|
@AndyButland Yeah, it seems we forgot to update the OpenApi.json file. There's a PR on V15 to update it and once it is on v15/dev, we can merge it to v16/dev and the changes should disappear here. |
AndyButland
approved these changes
Jan 29, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Looks good for me and correct to do this for 16.
I've just added an obsoletion for the property you have removed in the v15/dev branch.
Contributor
Author
Great initiative, thanks @AndyButland ! |
This was referenced Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates MaxRequestLength from
int?tolong?to allow for larger files to be uploaded. We expect the value to be set in kilobytes, then we multiply it by 1024, so you cannot even use the max of int32 without exceeding the max value. This means the total possible file size was around 2.5 GB, but with this change we can now allow files of essentially unlimited size.Also removes the option MaxQueryStringLength as it is no longer used. It was last used in V13.