Skip to content

Avoid wasting a whole thread watching for a filesystem change 😬 #18119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Matthew-Wise merged 1 commit into from
Jan 27, 2025
Merged

Avoid wasting a whole thread watching for a filesystem change 😬 #18119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Umbraco.Infrastructure/Runtime/FileSystemMainDomLock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public void CreateLockReleaseSignalFile() =>
public void DeleteLockReleaseSignalFile() =>
File.Delete(_releaseSignalFilePath);

private void ListeningLoop()
private async Task ListeningLoop()
{
while (true)
{
Expand All @@ -132,7 +132,7 @@ private void ListeningLoop()
break;
}

Thread.Sleep(_globalSettings.CurrentValue.MainDomReleaseSignalPollingInterval);
Copy link
Copy Markdown
Contributor

@PhyxionNL PhyxionNL Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is merged already, but this should really pass in the CancellationToken.

Copy link
Copy Markdown
Contributor

@mikecp mikecp Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PhyxionNL Thanks for the feedback 👍

Feel free to create your own PR and we'll gladly review it 😁

Copy link
Copy Markdown
Contributor Author

@JasonElkin JasonElkin Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy, we've chosen the red pill here...

Let me ask you: "What cancellation token"!?!?!

The one that comes from the private readonly CancellationTokenSource...?
The one that's not referenced from anything else... so is never actually cancelled!?!

await Task.Delay(_globalSettings.CurrentValue.MainDomReleaseSignalPollingInterval);
}
}
}