Fixed userResource request to get all users#18105
Merged
Conversation
Migaroez
approved these changes
Feb 11, 2025
Contributor
Migaroez
left a comment
There was a problem hiding this comment.
Works as expected, code looks good and can't find any issues with the added requirement as the Handler early returns when the query string does not contain the specified parameter and there are no methods that use the policy where the "ids" parameter is used in a different way.
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes: #12471
Description
This PR fixes the request
usersResource.getUsersthat you can issue from the backoffice in angularjs. It's not actually used in the backoffice code, but could be used in packages or custom backoffice extensions.There were two issues:
GetByIdsrequests in other controllers so it works now.To Test:
userResource: