Less parsing, allocation & LINQ when splitting strings

[Henr1k80]

Prerequisites

• I have added steps to test this contribution in the description below

Description

Less parsing, allocation & LINQ when splitting strings

[github-actions]

Hi there @Henr1k80, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[emmagarland]

Hi @Henr1k80

Thanks for your PR to optimise the string splitting.

One of the Core Collaborators team will review this as soon as possible.

Best wishes

Emma

[AndyButland]

All looks good here again, thanks @Henr1k80. I just added a small unit test to explicitly cover one of the methods you updated, so I could verify via that means that the refactoring hadn't changed anything with the output. Will merge this once the build server is happy.