Fix: Do not re-map schedule modal on error as it leads to broken bindings#17990
Merged
Migaroez merged 1 commit intorelease/13.6from Jan 15, 2025
Merged
Conversation
AndyButland
approved these changes
Jan 15, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Can confirm this does fix the issue and I don't see any ill-effects of removing this line. Should perhaps get a review from a FE-er just to see if they can see why this line may have been added in the past and what to look for that could break without it.
Contributor
Author
@nielslyngsoe Helped me figure out it was that line and that it only applies to that dialog so I think we are good 😄 |
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #17406