Fix: only fire event when instance is available (issue 17847)#17987
Merged
Fix: only fire event when instance is available (issue 17847)#17987
Conversation
Contributor
|
Looks good and behaves as advertised. Can't find a way to break it, so good to go! |
Migaroez
approved these changes
Jan 15, 2025
Migaroez
pushed a commit
that referenced
this pull request
Jan 15, 2025
* only fire event when instance is available * avoid js issue when no markup
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17847
Solution is to only fire this event if the instance is available, it seems to me if not available an update is not necessary.