Corrected property names and structure used in JSON schema generation for configuration of default data to install.#17946
Merged
nikolajlauridsen merged 1 commit intov13/devfrom Jan 13, 2025
Conversation
… for configuration of default data to install.
nikolajlauridsen
approved these changes
Jan 13, 2025
Contributor
nikolajlauridsen
left a comment
There was a problem hiding this comment.
Tested with VS code and got intellisens 👍
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Addresses the issue raised here: #17945
Description
As reported in the linked issue, the JSON schema generation for the default data you can configure for install isn't correct.
When merged this PR will ensure that the JSON schema generated is correct and matches the paths used in code. This will correct the intellisense provided when configuring Umbraco.
To Test:
src\Umbraco.Web.UI\appsettings-schema.Umbraco.Cms.json. You should now see the following elements:src\Umbraco.Web.UI\appSettings.jsonfile in an IDE that supports intellisense for configuration, and create anInstallDefaultDataelement underUmbraco:Cms. Verify the options you are presented with via intellisense match the documented configuration.