V15: Warn when content is unroutable#17837
Merged
Conversation
kjac
approved these changes
Jan 7, 2025
Contributor
kjac
left a comment
There was a problem hiding this comment.
Looks good to me 💪
Note that since the "new" backoffice is a lot less tightly coupled to the API controllers, we can't replicate the exact V13 behaviour. Effectively this means that there will be double warnings if both "domain warnings" and "unroutable content warnings" are triggered.
If this becomes a problem down the line, we'll have to refine the notifications system or maybe combine both warnings into one single notification handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
DocumentUrlServiceto not use the cache, as when we're getting theContentPublishedNotificationnotification, the cache is still not updated with the correct URL, and thus this didn't work.How to test