Skip to content

Health Check items "back to overview" link omits backoffice url segment#17828

Merged
AndyButland merged 1 commit intoumbraco:contribfrom
matthewcare:bugfix/health-check-link
Jan 21, 2025
Merged

Health Check items "back to overview" link omits backoffice url segment#17828
AndyButland merged 1 commit intoumbraco:contribfrom
matthewcare:bugfix/health-check-link

Conversation

@matthewcare
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Description

After running a health check in the settings section, and then clicking on an individual health check section, you press "back to overview" (probably shouldn't be hardcoded text?). This would push a URL missing the umbraco/ portion. Whilst the CMS continues to work, if you refresh your page you're taken away from the backoffice, probably ending up on the 404 page.

Image to show the area I mean specifically
image

"Back to overview" would push the wrong url to the history, which would break things if you reloaded your page
@github-actions
Copy link

github-actions bot commented Dec 17, 2024

Hi there @matthewcare, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey @matthewcare, good spot! Thanks for fixing this one, someone on the core collaborators team will review this soon 😄

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and can confirm this resolves the issue, thanks @matthewcare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants