Health Check items "back to overview" link omits backoffice url segment#17828
Conversation
"Back to overview" would push the wrong url to the history, which would break things if you reloaded your page
|
Hi there @matthewcare, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Hey @matthewcare, good spot! Thanks for fixing this one, someone on the core collaborators team will review this soon 😄 |
AndyButland
left a comment
There was a problem hiding this comment.
Tested and can confirm this resolves the issue, thanks @matthewcare.
Prerequisites
Description
After running a health check in the settings section, and then clicking on an individual health check section, you press "back to overview" (probably shouldn't be hardcoded text?). This would push a URL missing the
umbraco/portion. Whilst the CMS continues to work, if you refresh your page you're taken away from the backoffice, probably ending up on the 404 page.Image to show the area I mean specifically
