hotfix: no need to redirect when removing tab. router handles this fine#17780
Merged
iOvergaard merged 1 commit intorelease/15.1from Dec 11, 2024
Merged
Conversation
nielslyngsoe
changed the title
madsrasmussen
approved these changes
Dec 11, 2024
Member
madsrasmussen
left a comment
madsrasmussen
left a comment
There was a problem hiding this comment.
Changes look good, and it is now possible to delete tabs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue when removing tab from a document type, but it was only a problem when user was on another tab than the one to be deleted.
Fixes #17771
see
https://umbraco.slack.com/archives/C027U315T54/p1733894530378609?thread_ts=1733894482.267889&cid=C027U315T54
Notice, the problem seemed to be a re-direct and this was not needed anymore, the router seems to handle this fine by its own redirects.
Prerequisites
If there's an existing issue for this PR then this fixes
Description