Fix create child issue in list view with infinite editor (#13355).#17637
Fix create child issue in list view with infinite editor (#13355).#17637AndyButland merged 1 commit intoumbraco:v13/contribfrom
Conversation
|
Hi there @mvennevold, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Hello @mvennevold ! Thanks for providing a fix for this issue on V13 👍 In the meantime, I noticed this is your first contribution to the Umbraco CMS. Thank you and congratulations😁 !! |
AndyButland
left a comment
There was a problem hiding this comment.
I've tested this and can confirm it resolves the issue, thanks very much @mvennevold.
Prerequisites
If there's an existing issue for this PR then this fixes #13355
Description
The linked issue is for v10 but I ran into the same issue in 13.5.2.
Based on @dKumarmj 's analysis in the issue I have tried to fix the problem.
Instead of using the id in the route to fetch the allowed child items we should use the contentId from the scope which represents the active item in the infinite editor.
With this fix in place the repro steps in the issue now work as expected, i.e. it is possible to create a third level item under the second level.