V15: Show a loader during the login procedures rather than oddly styled content#17618
Merged
leekelleher merged 4 commits intov15/devfrom Nov 25, 2024
Merged
V15: Show a loader during the login procedures rather than oddly styled content#17618leekelleher merged 4 commits intov15/devfrom
leekelleher merged 4 commits intov15/devfrom
Conversation
if the flow fails, the app-error component will be shown, or if the flow is initialised inside a popup (i.e. the session was lost)
…hname it should work better by checking the `startsWith` comparing the pathname, and besides, it seems to work better for the understanding of the function to inverse the true/false check
leekelleher
approved these changes
Nov 25, 2024
Member
leekelleher
left a comment
There was a problem hiding this comment.
Tested out, works as expected! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17453
hasOwnOpenerdid not work (at least not on the Vite server)How to test
Hint: You can force the "login landing page" by going to https://localhost:44339/umbraco/oauth_complete and appending
?code=testto see the success variant and omitting the?codeparameter to see the failure variant.