Run both cms and package migrations in upgrader#17575
Merged
nikolajlauridsen merged 2 commits intov13/devfrom Nov 20, 2024
Merged
Run both cms and package migrations in upgrader#17575nikolajlauridsen merged 2 commits intov13/devfrom
nikolajlauridsen merged 2 commits intov13/devfrom
Conversation
bergmania
requested changes
Nov 19, 2024
bergmania
approved these changes
Nov 19, 2024
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17436
The problem was that the upgrader only ever ran either CMS upgrades or package upgrades, this has been updated so both are run if needed.
Not that the CMS and package upgrades run in their own separate scopes, so it's safe to do it in a single notification handler 😄
Testing
Add both a CMS NoopMigration in
UmbracoPlanand a package plan, unable unattended upgrades, and ensure both are run if needed.Example package migration plan