Feature: Content Type Workspace Context Base#17542
Merged
madsrasmussen merged 35 commits intov15/devfrom Nov 18, 2024
Merged
Conversation
...raco.Web.UI.Client/src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts
Show resolved
Hide resolved
Member
|
Read the code, looks very good — next step for me would be to test the application. Notice there is a type issue, see the build. |
Contributor
Author
Type issues are fixed now 🤦 Thanks! |
nielslyngsoe
approved these changes
Nov 18, 2024
madsrasmussen
deleted the
v15/feature/content-type-workspace-context-base
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a ContentTypeWorkspaceContextBase that contains all the shared logic across the content type contexts.
With these changes, we also extend the EntityDetailContextBase and automatically include the "Discard Changes" functionality for all Content-Type workspaces.
What to test: