Made some stylesheet endpoints available for document/media/member re…#17442
Merged
nikolajlauridsen merged 1 commit intov15/devfrom Nov 8, 2024
Merged
Made some stylesheet endpoints available for document/media/member re…#17442nikolajlauridsen merged 1 commit intov15/devfrom
nikolajlauridsen merged 1 commit intov15/devfrom
Conversation
nikolajlauridsen
approved these changes
Nov 8, 2024
Contributor
nikolajlauridsen
left a comment
nikolajlauridsen
left a comment
There was a problem hiding this comment.
Looks good, tests good 👍
|
Will this fix be released in a minor fix for Umbraco 14? If so when? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17084
Description
Fixes stylesheet access during content related actions, like editing a document with an rte that uses a stylesheet.
Testing
See preproduction steps in linked issue and also tests whether the other stylesheet endpoints are still properly protected. Also test for similar issues on media and members with rte properties
Notes
Should be cherry picked for the next v14 minor