Fix has pending package migrations#17423
Merged
nikolajlauridsen merged 5 commits intov15/devfrom Nov 6, 2024
Merged
Conversation
…s had pending migrations from the management api endpoint, without actually have it.
…-pending-package-migrations # Conflicts: # src/Umbraco.Web.UI.Client
nikolajlauridsen
approved these changes
Nov 6, 2024
Contributor
nikolajlauridsen
left a comment
nikolajlauridsen
left a comment
There was a problem hiding this comment.
Looks good, tests good 👍
nikolajlauridsen
deleted the
v15/hotfix/fix-has-pending-package-migrations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17437, where packages with package migration did report "hasPendingMigrations" when it did not.
The issue seems to happen, when the package Name is different from the package Id.
Tests
/umbraco/management/api/v1/package/migration-statusendpoint and verify there is no pending if the package migrations are executed on boot.