V13: Use updated form components in the login form#17281
Merged
leekelleher merged 3 commits intov13/devfrom Oct 17, 2024
Merged
V13: Use updated form components in the login form#17281leekelleher merged 3 commits intov13/devfrom
leekelleher merged 3 commits intov13/devfrom
Conversation
Cherry-picked a fix from V14 where the custom login input component was no longer needed, which was fixed because it errors out. This simplifies the login form.
iOvergaard
changed the title
iOvergaard
added
release/13.6.0
javascript
leekelleher
requested changes
Oct 16, 2024
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
Tested out. Overall it works, but there's a slight regression.
If you press Enter on the password field (after entering a password), the form does not submit. I tried this out on the main v13/dev branch and I was able to do this.
Contributor
Author
|
Excellent catch, @leekelleher. Thinking back to V14, we had to fix this explicitly there as well. I have cherry-picked the code we used back then. Would you check again, please? |
leekelleher
approved these changes
Oct 17, 2024
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
Re-tested, all good with the Enter submitting! 🙌
iOvergaard
changed the title
iOvergaard
added
type/feature
and removed
dependencies
|
Since updating to 13.6.0 the login form shows this: |
Contributor
|
Tracked under #18191 @Wolfkhan66 |
This was referenced Sep 28, 2025
This was referenced Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates @umbraco-ui/uui to the latest 1.11.0.
Also cherry-picked a fix from V14 where the custom login input component was no longer needed, which was fixed because it errors out. This simplifies the login form.
How to test
Make sure that the login form works.