Content.EditorDirectiveController: added formSubmittedValidationFailed broadcast to prevent fields to stay disabled#17018
Conversation
…d broadcast to prevent fields to stay disabled
|
Hi there @Yinzy00, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Hey @Yinzy00 thank you for your PR! Someone on the Core Collaborators team will review this soon 😄 |
nielslyngsoe
left a comment
There was a problem hiding this comment.
Thanks, good catch. I have tested and it works!
…d broadcast to prevent fields to stay disabled (umbraco#17018)
Content.EditorDirectiveController: added formSubmittedValidationFailed broadcast to prevent fields to stay disabled
Prerequisites
If there's an existing issue for this PR then this fixes #17019
Version
v13.5.0 RC
Description
#16961 resolved an issue with content saving.
We discovered that when attempting to save and publish with invalid fields, those fields remained disabled. After some investigation, we found that triggering the formSubmittedValidationFailed broadcast resolved the problem.
Steps to reproduce
=> After validation text fields (and blocklist, mediapicker, ...) will stay disabled
In collab with @NielsAudoor ;)