Merged
Conversation
bergmania
requested changes
Sep 9, 2024
Member
bergmania
left a comment
bergmania
left a comment
There was a problem hiding this comment.
Breaking changes and functionality 🙈
...mbraco.Cms.Api.Management/Controllers/Document/References/AreReferencedDocumentController.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Core/Persistence/Repositories/ITrackedReferencesRepository.cs
Show resolved
Hide resolved
...mbraco.Cms.Api.Management/Controllers/Document/References/AreReferencedDocumentController.cs
Show resolved
Hide resolved
…ed-references # Conflicts: # src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs # src/Umbraco.Infrastructure/Persistence/SqlContextExtensions.cs
Member
|
I retargeted for 15.1 |
bergmania
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to reduce both the sql complexity and the data transfered from DB trough all the layers out to the api to improve performance.
A performance increase of about 25% percent has been noted across 2 different computers with the same test method: peak load testing with postman collections.
Testing
You can ask me for a DB or connection to it that has a decent set of data (30k+ nodes). From this DB you should pick a random amount of node Ids and run them trough the altered document and media endpoints to see if you get the same results back as in the unmodified versions.
endpoints in question