Merged
Conversation
…htext object (still with json) can be required or not. We are now testing the markdown needs to have a value
Migaroez
approved these changes
Aug 26, 2024
Contributor
Migaroez
left a comment
Migaroez
left a comment
There was a problem hiding this comment.
✅ Code looks good
✅ Tests out as expected
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15993
Description
This fixes a bug, where the mandatory check did not work on RTEs, after the markdown have been wrapped in json.
To fix it, a new custom RichTextRequiredValidator have been introduced. It inherits the original RequiredValidator and passes the markdown to that.
Test
Notes for when merged to v14