Ignore Visual Studio's generated launchSettings file.#16951
Conversation
|
Hi there @JasonElkin, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Hey @JasonElkin thanks for your PR 😄 someone on the core collaborators team will review this soon 😜 |
|
Thanks Jason for your PR its a file I keep having to dodge as well 👍 |
|
Same! Nice one |
The Umbraco.Tests.AcceptanceTest.UmbracoProject project is not a real web application and can't be run, but when Visual Studio sees the SDK it adds a launchSettings file.
This PR just ignores the file to prevent contributors that are using Visual Studio from accidentally adding it in their PRs.