Templates can still be editable when using runtime mode Production bug fixed #16622

[nick-hoang]

Prerequisites

• [] I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes (#16622)

Description

[github-actions]

Hi there @nick-hoang, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[emmagarland]

Hi @nick-hoang,

Thanks for your PR to fix #16622, where templates can still be editable when using the Production runtime mode.

It looks like this is your first PR to this repository! Nice work! #H5YR 🎉

I've noticed this has changed thousands of files and I'm wondering if something might have gone awry with the merge? Let us know if you need any help getting this PR ship-shape.

Best wishes

Emma

[nick-hoang]

hi @emmagarland

I've just changed the file src/Umbraco.Web.UI.Client/src/views/templates/edit.html, you can see my last commit here: 60eb16f

Other commits are not from me, I have no idea why they are included in my PR. These commits came when I pulled and merged new commits from the v13/contrib branch into my fork repo.

Hope it help.
Cheers

[emmagarland]

Thanks @nick-hoang

I think that is because this pull request is targetting v14 ('contrib' branch), whereas 'v13/contrib' is the branch to target for v13. Which Umbraco version are you trying to work with?

Best wishes

Emma

[JasonElkin]

The rogue commit was reversible, so I've reverted it. I've retargeted to v13, which is where this was forked from and more importantly where the file being modified still exists.

[emmagarland]

The rogue commit was reversible, so I've reverted it. I've retargeted to v13, which is where this was forked from and more importantly where the file being modified still exists.

Nice one @JasonElkin - I'll see if I can take a look later

[JasonElkin]

Hey @nick-hoang, thanks for fixing this!

And congratulations on having your first PR merged to Umbraco 🙌🎉

I see you have a profile on https://our.umbraco.com/, I'll get you assigned one of those shiny contributor badges.

Thanks again,
Jas