V13: fix 16663#16866
Merged
Merged
Conversation
# Conflicts: # src/Umbraco.Web.UI.Client/src/common/services/tinymce.service.js
leekelleher
approved these changes
Aug 13, 2024
leekelleher
left a comment
Member
There was a problem hiding this comment.
Tested out, blocks pasted into the RTE (from the blocks clipboard) have a unique UDI. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16663
This PR includes the changes of #16864 as that solved a build issue.
The problem that is not clearly known by this reporter, is that if a Block shared UDI with another block it will be problematic in the front-end cache, as we use the block UDI as its identifier. This means we always have to make sure that blocks are unique.
This PR registres a Backoffice Clipboard Paste Resolver, which updates the UDIs of Blocks of an RTE with new once.
From my testing this is already handled when duplicating documents, so the C# resolver does already handle this case. — Just a note to mention that, that case is already handled.