Skip to content

Don't shrink crops container on right side#16827

Merged
lauraneto merged 1 commit intoumbraco:v13/contribfrom
bjarnef:patch-9
Nov 18, 2024
Merged

Don't shrink crops container on right side#16827
lauraneto merged 1 commit intoumbraco:v13/contribfrom
bjarnef:patch-9

Conversation

@bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 26, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Description

I noticed on a few on our projects the image (mainly at "root" Media item in crops sidebar) in flexbox container can grow and thus shrink crops on right side.

In v14 this looks correct.

Before

image

image

After

image

@github-actions
Copy link

github-actions bot commented Jul 26, 2024

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@lauraneto
Copy link
Contributor

Hi @bjarnef ,
Thank you for the pull request!
We will look into it as soon as possible. 🙂

@bjarnef
Copy link
Contributor Author

bjarnef commented Sep 28, 2024

@lauraneto any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants