Improve migration performance#16784
Merged
Merged
Conversation
kjac
reviewed
Jul 29, 2024
kjac
reviewed
Jul 29, 2024
kjac
reviewed
Jul 30, 2024
…properly and sqlLite datasets should not be large anyway
nul800sebastiaan
added
category/performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates 2 existing migrations to be more performant. Both Cloud and heartcore have had issues with timeout regarding these performances.
The Heartcore team made a workaround (pre migration) on which these changes are based.
v12 migration
A result differential has been performed between the old and new migration with a large production copy database. No differences were found in the result.
v10 migration
A large amount of nodes with tags were generated, the differential again showed no differences in the result.
note
Testing should be done against a Sql-Server DB.