Skip to content

Fix/15770 dynamic roots issues#16770

Closed
bielu wants to merge 2 commits intoumbraco:contribfrom
bielu:fix/15770-dynamic-roots-issues
Closed

Fix/15770 dynamic roots issues#16770
bielu wants to merge 2 commits intoumbraco:contribfrom
bielu:fix/15770-dynamic-roots-issues

Conversation

@bielu
Copy link
Contributor

@bielu bielu commented Jul 9, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #15770

Description

This pr adding fallbacks to Root and Site root queries, but also add new query root, which allows to usage of Parent or Self in mntp.

@github-actions
Copy link

github-actions bot commented Jul 9, 2024

Hi there @bielu, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey Arkadiusz! Thanks for the PR, someone on the core collaborators team will review this soon 🥳

@JasonElkin
Copy link
Contributor

Hey @bielu, sorry this didn't get picked up sooner.

There's a few issues here that, in combination, means I'm going to need to close this.

  1. This is blocked on Customly register DynamicRootOriginFinders are not display in UI #16881 so it's impossible to test as things stand.
  2. This is targeting contrib, not v13/contrib, and as far as I can tell this is a v13 only issue.
  3. There are incoming fixes in MNTP: Re-initialize contextual dialog options upon content creation #17301 and MNTP: Improve site and root context for dynamic root #17303 that will supersede the fixes in here.

If you'd still like to contribute a Parent or Self option then happy to reopen with just that once there's a fix for #16881 in place.

Thanks for taking the time to look at this!

@JasonElkin JasonElkin closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multinode treepicker dynamic path only works after refresh

3 participants