Skip to content

Allow http for openiddict#16614

Merged
elit0451 merged 1 commit into
v14/devfrom
v14/bugfix/allow-http-requests-when-usehttps-is-false
Jun 19, 2024
Merged

Allow http for openiddict#16614
elit0451 merged 1 commit into
v14/devfrom
v14/bugfix/allow-http-requests-when-usehttps-is-false

Conversation

@bergmania

@bergmania bergmania commented Jun 18, 2024

Copy link
Copy Markdown
Member

Description

Added post configuration of OpenIddictServerOptions that removes the ValidateTransportSecurityRequirement iff GlobalSettings.UseHttps is false.

Fixing: #16605

Test

Please note that openiddict only allow connections from the host that first attempted to access backoffice. It can make it easier to set launchBrowser to false in launchSettings.json

…ValidateTransportSecurityRequirement iff globalsettings.usehttps is false.

@elit0451 elit0451 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and tests out good 💪

@elit0451 elit0451 merged commit 75c42f4 into v14/dev Jun 19, 2024
@elit0451 elit0451 deleted the v14/bugfix/allow-http-requests-when-usehttps-is-false branch June 19, 2024 13:21
@kevinchalet

Copy link
Copy Markdown

👋🏻

FYI: removing the ValidateTransportSecurityRequirement event handler is not necessary to disable the TLS/HTTPS requirement as there's a dedicated OpenIddictServerAspNetCoreOptions.DisableTransportSecurityRequirement option that allows disabling this security check (when set to true, the built-in ValidateTransportSecurityRequirement handler is not called) 😃

Cheers.

@bergmania

bergmania commented Jun 19, 2024

Copy link
Copy Markdown
Member Author

I simplified the PR here #16629. Thanks for the input @kevinchalet 💪

@kevinchalet

Copy link
Copy Markdown

You're welcome @bergmania 😄

On a related note, OpenIddict 5.7.0 just shipped: https://github.com/openiddict/openiddict-core/releases/tag/5.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants