V13: Move publishing notification after validation#16331
Merged
Migaroez merged 1 commit intoMay 22, 2024
Conversation
Migaroez
approved these changes
May 22, 2024
Migaroez
left a comment
Contributor
There was a problem hiding this comment.
Solves the issue/discussion as advertised.
Had some concerns about functional changes but the magic Success based on the bit value of the OperationStatuses seems to take it all into account 👍
Contributor
|
With this pr in place, if the content is changed during ContentPublishingNotification, the content is left in Published (Pending Changes) state. E.g. if you want to set a field value at the time of publishing (e.g. a record of when the content was first published) it now shows no extra current version created and Published (Pending Changes) state which is a breaking change. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
How to test