Skip to content

V14: Fix package creation#16309

Merged
Zeegaan merged 2 commits into
v14/devfrom
v14/fix/fix-package-creation
May 17, 2024
Merged

V14: Fix package creation#16309
Zeegaan merged 2 commits into
v14/devfrom
v14/fix/fix-package-creation

Conversation

@nikolajlauridsen

Copy link
Copy Markdown
Contributor

Fixes package creation.

The first half was changed to use keys, however the CreatedPackageSchemaRepository tried to parse them as ints, leading to nothing being added to the package.xml

This PR fixes this by using guids instead.

Testing

  1. Try making a package with various entities, documents, templates etc.
  2. Check the package.xml and ensure the entities are present

@Zeegaan Zeegaan merged commit 13f2d52 into v14/dev May 17, 2024
@Zeegaan Zeegaan deleted the v14/fix/fix-package-creation branch May 17, 2024 10:30
@Zeegaan

Zeegaan commented May 17, 2024

Copy link
Copy Markdown
Member

LGTM 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants