Translate member picker property editor value to V14 compatible format (and back again)#16149
Merged
Merged
Conversation
…t (and back again)
1 task
…ix/member-picker-propertye-editor-value
elit0451
approved these changes
Apr 29, 2024
elit0451
left a comment
elit0451
left a comment
Contributor
There was a problem hiding this comment.
Looks good 💪
Will merge soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The member picker property editor stores the
Udiof the picked member (or the integerIdin really old databases). However, the V14 client needs the member key to resolve the member data in the editor UI, so we need to translate the value back and forth.Testing this PR
The member picker property editor UI should work and should be able to store and retrieve a picked member.
Important: The current member picker property editor UI supports picking multiple members. That's a mistake, which will be corrected soon. The editor only supports picking a single member in V13, and thus it should do the same in V14. In other words, don't expect this PR to work if you pick more than a single member 😆