Skip to content

V14: Migrate notify action from char to string #16142

Merged
bergmania merged 5 commits into
v14/devfrom
v14/feature/migrate-content-notification-identifiers
Apr 25, 2024
Merged

V14: Migrate notify action from char to string #16142
bergmania merged 5 commits into
v14/devfrom
v14/feature/migrate-content-notification-identifiers

Conversation

@nikolajlauridsen

Copy link
Copy Markdown
Contributor

Migrates the umbracoUser2NodeNotify.action column use the new action strings instead of the action letters. This involves changing the column type to Nvarchar(255), and mapping the action letters to the new action strings.

Additionally this also migrates the umbracoUserGroup2Permission.permission column to use Nvarchar(255), partly just to align the two, since it's referencing the same thing, but this will also allow for a compound key in the future.

Testing

On both Sqlite and MSSQL:

  1. Ensure SMTP is configured
  2. Create some content in v13
  3. Enable notifications for the content
  4. Migrate the database to v14.
  5. The values in the mentioned tables should now be updated (except for 'H', since that's a deploy thing)
  6. Content notifications should now work

@bergmania bergmania left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests good

@bergmania bergmania merged commit 9fc083f into v14/dev Apr 25, 2024
@bergmania bergmania deleted the v14/feature/migrate-content-notification-identifiers branch April 25, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants