v14: JSON schema tool improvements#16035
Merged
Conversation
bergmania
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating the JsonSchema tool in PR #16030, I copied over the same changes to our commercial products (because this tool isn't reusable yet, see PR #13560). This required doing some adjustments, which can be brought back to the CMS.
The biggest change is that the JSON schema generator now checks the
IgnoreReadOnlyPropertiessetting to conditionally remove read-only properties (which probably should be supported OOTB byNJsonSchema). All properties on the schema class now use the required modifier instead of setting null-suppressed default values and I've made the fullUmbracoPathproperty obsolete, so the obsolete setter work-around can be removed as well.To test, rebuild the Umbraco.Cms.Targets project (or remove the
appsettings-schema.Umbraco.Cms.jsonfile and start a build) and check whether the generated file is the same as before.