Moved logic from FolderTreeControllerBase service layer#15976
Merged
Conversation
Contributor
|
The code looks great and the whole thing tests out really well. ✅ Pagination works However, I think the custom ordering should have been added to Here's what I see in the UI (and in the endpoint outputs too): Data types:Media types:When moving the custom ordering to data types from media types, the folders are correctly placed at the top: Data types:Media types:It kinda also makes sense when considering it's an alphanumeric sorting on
I'll take the liberty of pushing those changes 😄 |
kjac
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
This PR moves some logic from the
FolderTreeControllerBaseinto theEntityServiceandEntityRepository.This required the repository to support multiple orderings statements. To make this part non-breaking, I added a
Ordering? Nextproperty on theOrderingclass, that is currently only supported by theEntityRepository.Test