Skip to content

V14 QA Fixed the failing tests due to UI changes #15944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andr317c merged 8 commits into from
Apr 2, 2024
Merged

V14 QA Fixed the failing tests due to UI changes #15944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a42970f
Bumped version of test helper
nhudinh0309 Mar 26, 2024
f9378a5
Changed clickCreateButton to clickCreateLink due to UI changes
nhudinh0309 Mar 26, 2024
df2d13d
Bumped version of json builder
nhudinh0309 Mar 27, 2024
9ff8c73
Changed delete folder method
nhudinh0309 Mar 27, 2024
ce690ab
Merge branch 'v14/dev' into v14/QA/fix-failing-tests
nhudinh0309 Mar 27, 2024
8e0f81b
Bumped version of test helper
nhudinh0309 Mar 28, 2024
1b0ce8b
Merge branch 'v14/dev' into v14/QA/fix-failing-tests
nhudinh0309 Mar 28, 2024
e495dca
Added skip tests since currently only can view relations
nhudinh0309 Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions tests/Umbraco.Tests.AcceptanceTest/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tests/Umbraco.Tests.AcceptanceTest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
"wait-on": "^7.2.0"
},
"dependencies": {
"@umbraco/json-models-builders": "^2.0.1 ",
"@umbraco/playwright-testhelpers": "^2.0.0-beta.21",
"@umbraco/json-models-builders": "^2.0.4",
"@umbraco/playwright-testhelpers": "^2.0.0-beta.25",
"camelize": "^1.0.0",
"dotenv": "^16.3.1",
"faker": "^4.1.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Dictionary/Dictionary.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ test.describe('Dictionary tests', () => {
await umbracoUi.dictionary.goToSection(ConstantHelper.sections.dictionary);

// Act
await umbracoUi.dictionary.clickCreateButton();
await umbracoUi.dictionary.clickCreateLink();
await umbracoUi.dictionary.enterDictionaryName(dictionaryName);
await umbracoUi.dictionary.clickSaveButton();

Expand Down
6 changes: 3 additions & 3 deletions tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Relation Types/RelationTypes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ test.describe('Relation types tests', () => {
// TODO: when frontend is ready, verify the new relation type name is displayed in the Relation Types tree
});

test('can update name of a relation type', async ({umbracoApi, umbracoUi}) => {
test.skip('can update name of a relation type', async ({umbracoApi, umbracoUi}) => {
// Arrange
const wrongRelationTypeName = 'Updated Relation Type';
await umbracoApi.relationType.ensureNameNotExists(wrongRelationTypeName);
Expand All @@ -51,7 +51,7 @@ test.describe('Relation types tests', () => {
expect(await umbracoApi.relationType.doesNameExist(wrongRelationTypeName)).toBeFalsy();
});

test('can update direction value of a relation type', async ({umbracoApi, umbracoUi}) => {
test.skip('can update direction value of a relation type', async ({umbracoApi, umbracoUi}) => {
// Arrange
relationTypeId = await umbracoApi.relationType.create(relationTypeName, false, false, objectTypeId, objectTypeId);

Expand All @@ -66,7 +66,7 @@ test.describe('Relation types tests', () => {
expect(relationTypeData.isBidirectional).toEqual(true);
});

test('can update isDependency value of a relation type', async ({umbracoApi, umbracoUi}) => {
test.skip('can update isDependency value of a relation type', async ({umbracoApi, umbracoUi}) => {
// Arrange
const updatedObjectTypeName = 'Media';
relationTypeId = await umbracoApi.relationType.create(relationTypeName, false, false, objectTypeId, objectTypeId);
Expand Down
2 changes: 1 addition & 1 deletion ...o.Tests.AcceptanceTest/tests/DefaultConfig/Settings/PartialView/PartialViewFolder.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test.describe('Partial View Folder tests', () => {
// Act
await umbracoUi.partialView.clickRootFolderCaretButton();
await umbracoUi.partialView.clickActionsMenuForPartialView(folderName);
await umbracoUi.partialView.deletePartialView();
await umbracoUi.partialView.deleteFolder();

// Assert
await umbracoUi.partialView.isSuccessNotificationVisible();
Expand Down