Use IHttpClientFactory when executing webhooks and add a little more context in headers#15378
Closed
kjac wants to merge 1 commit intorelease/13.0from
Closed
Use IHttpClientFactory when executing webhooks and add a little more context in headers#15378kjac wants to merge 1 commit intorelease/13.0from
kjac wants to merge 1 commit intorelease/13.0from
Conversation
…context in headers
Contributor
Author
|
Well that's silly... this is somewhat a duplicate of #15375 🤦 |
ronaldbarendse
deleted the
v13/fix/webhook-firing-httpclientfactory-headers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #15238 (partial fix)
Description
The linked discussion revolves around supplying additional context when executing a webhook. As it happens, webhooks already append the triggering event name as an
Umb-Webhook-Eventrequest header when executing.This PR ensures that:
IHttpClientFactoryto create HTTP clients instead of new'ing them up when executing a webhook.Umb-Webhook-RetryCount).