Skip to content

Fixing PR #15318 which updated an interface, which is breaking#15363

Merged
nul800sebastiaan merged 2 commits intorelease/13.0from
temp-fix-pr-15318
Dec 5, 2023
Merged

Fixing PR #15318 which updated an interface, which is breaking#15363
nul800sebastiaan merged 2 commits intorelease/13.0from
temp-fix-pr-15318

Conversation

@nul800sebastiaan
Copy link
Copy Markdown
Member

While technically a breaking change, it was not expected this interface was in use by anyone. However, to be safe, this fixes the breaking change by providing a default implementation.

Copy link
Copy Markdown
Contributor

@ronaldbarendse ronaldbarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the default implementations to not throw exceptions anymore, but instead return a sensible default 👍🏻

@nul800sebastiaan nul800sebastiaan merged commit a6b53b0 into release/13.0 Dec 5, 2023
@nul800sebastiaan nul800sebastiaan deleted the temp-fix-pr-15318 branch December 5, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants