Change WebhookEventCollectionBuilder to set collection#15351
Merged
Change WebhookEventCollectionBuilder to set collection#15351
WebhookEventCollectionBuilder to set collection#15351Conversation
1 task
Contributor
Author
|
I've updated this PR to fix/also update the |
Member
|
LGTM 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
As discussed in #15345 (comment), the UI for webhook events now contains a search bar and already orders them by
eventName, so there's no reason for registering them in any specific order.Although changing the base class from
OrderedCollectionBuilderBasetoSetCollectionBuilderBaseis a simple change, it does mean you have to useAdd<T>()instead ofAppend<T>()to add registrations, which does mean it's a breaking change. I don't think it warrants adding a similar method that simply forwardsAppend<T>() => Add<T>(), as we've only released it in RCs and should keep the final release as clean as possible.