V13 RC: Fix regression for external login providers#15334
Merged
iOvergaard merged 5 commits intov13/devfrom Dec 1, 2023
Merged
V13 RC: Fix regression for external login providers#15334iOvergaard merged 5 commits intov13/devfrom
iOvergaard merged 5 commits intov13/devfrom
Conversation
… screen to avoid autoredirect to external login
…nd externalLoginResponse (they are always the same)
bergmania
approved these changes
Nov 30, 2023
Member
bergmania
left a comment
bergmania
left a comment
There was a problem hiding this comment.
Code changes looks good, but maybe we can do a video 1-1 to do the test together, so I don't have to setup all the external login providers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes AB#35485
If you turn on
AutoRedirectLoginToExternalProviderit will send you in an endless loop, because we now redirect the user when logging out. This PR adds a check for the parameter?logout=truein the BackOfficeController to prevent this scenario. It also refactors the controller to reduce nesting and improve the general understanding of how external login providers work.