Skip to content

Allow fetching multiple content and media by Guid and Udi #15289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyButland merged 4 commits into from
Sep 20, 2025
Merged

Allow fetching multiple content and media by Guid and Udi #15289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
359299b
Allow fetching content by Guid and Udi
bjarnef Nov 23, 2023
38c8570
Get media by Guid and Udi ids
bjarnef Nov 23, 2023
8a522db
Fix array parameters
bjarnef Nov 23, 2023
cc417c9
Merge branch 'v13/dev' into feature/content-by-guid-udi
bjarnef Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/Umbraco.Web.BackOffice/Controllers/ContentController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Net.Mime;

Check warning on line 1 in src/Umbraco.Web.BackOffice/Controllers/ContentController.cs

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Number of Functions in a Single Module 

This module has 77 functions, threshold = 75. This file contains too many functions. Beyond a certain threshold, more functions lower the code health.

Check notice on line 1 in src/Umbraco.Web.BackOffice/Controllers/ContentController.cs

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev)

✅ Getting better: Overall Code Complexity 

The mean cyclomatic complexity decreases from 5.83 to 5.70, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
using System.Text;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http.Extensions;
Expand Down Expand Up @@ -44,6 +44,7 @@
[PluginController(Constants.Web.Mvc.BackOfficeApiArea)]
[Authorize(Policy = AuthorizationPolicies.TreeAccessDocuments)]
[ParameterSwapControllerActionSelector(nameof(GetById), "id", typeof(int), typeof(Guid), typeof(Udi))]
[ParameterSwapControllerActionSelector(nameof(GetByIds), "ids", typeof(int[]), typeof(Guid[]), typeof(Udi[]))]
[ParameterSwapControllerActionSelector(nameof(GetNiceUrl), "id", typeof(int), typeof(Guid), typeof(Udi))]
public class ContentController : ContentControllerBase
{
Expand Down Expand Up @@ -247,6 +248,30 @@
return foundContent.Select(MapToDisplay).WhereNotNull();
}

/// <summary>
/// Return content for the specified ids
/// </summary>
/// <param name="ids"></param>
/// <returns></returns>
[FilterAllowedOutgoingContent(typeof(IEnumerable<ContentItemDisplay>))]
public IEnumerable<ContentItemDisplay> GetByIds([FromQuery] Guid[] ids)
{
IEnumerable<IContent> foundContent = _contentService.GetByIds(ids);
return foundContent.Select(MapToDisplay).WhereNotNull();
}

/// <summary>
/// Return content for the specified ids
/// </summary>
/// <param name="ids"></param>
/// <returns></returns>
[FilterAllowedOutgoingContent(typeof(IEnumerable<ContentItemDisplay>))]
public IEnumerable<ContentItemDisplay> GetByIds([FromQuery] Udi[] ids)
{
IEnumerable<IContent> foundContent = _contentService.GetByIds(ids)!;
return foundContent.Select(MapToDisplay).WhereNotNull();
}

/// <summary>
/// Updates the permissions for a content item for a particular user group
/// </summary>
Expand Down
25 changes: 25 additions & 0 deletions src/Umbraco.Web.BackOffice/Controllers/MediaController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Globalization;

Check notice on line 1 in src/Umbraco.Web.BackOffice/Controllers/MediaController.cs

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev)

✅ Getting better: Overall Code Complexity 

The mean cyclomatic complexity decreases from 6.58 to 6.15, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
using System.Net.Mime;
using System.Text;
using Microsoft.AspNetCore.Authorization;
Expand Down Expand Up @@ -47,6 +47,7 @@
[PluginController(Constants.Web.Mvc.BackOfficeApiArea)]
[Authorize(Policy = AuthorizationPolicies.SectionAccessMedia)]
[ParameterSwapControllerActionSelector(nameof(GetById), "id", typeof(int), typeof(Guid), typeof(Udi))]
[ParameterSwapControllerActionSelector(nameof(GetByIds), "ids", typeof(int[]), typeof(Guid[]), typeof(Udi[]))]
[ParameterSwapControllerActionSelector(nameof(GetChildren), "id", typeof(int), typeof(Guid), typeof(Udi))]
public class MediaController : ContentControllerBase
{
Expand Down Expand Up @@ -296,6 +297,30 @@
return foundMedia.Select(media => _umbracoMapper.Map<MediaItemDisplay>(media));
}

/// <summary>
/// Return media for the specified ids
/// </summary>
/// <param name="ids"></param>
/// <returns></returns>
[FilterAllowedOutgoingMedia(typeof(IEnumerable<MediaItemDisplay>))]
public IEnumerable<MediaItemDisplay?> GetByIds([FromQuery] Guid[] ids)
{
IEnumerable<IMedia> foundMedia = _mediaService.GetByIds(ids);
return foundMedia.Select(media => _umbracoMapper.Map<MediaItemDisplay>(media));
}

/// <summary>
/// Return media for the specified ids
/// </summary>
/// <param name="ids"></param>
/// <returns></returns>
[FilterAllowedOutgoingMedia(typeof(IEnumerable<MediaItemDisplay>))]
public IEnumerable<MediaItemDisplay?> GetByIds([FromQuery] Udi[] ids)
{
IEnumerable<IMedia> foundMedia = _mediaService.GetByIds(ids);
return foundMedia.Select(media => _umbracoMapper.Map<MediaItemDisplay>(media));
}

/// <summary>
/// Returns a paged result of media items known to be of a "Folder" type
/// </summary>
Expand Down
Loading