Delivery API: Fix numeric and date based filters#15286
Merged
elit0451 merged 2 commits intorelease/13.0from Nov 27, 2023
Merged
Delivery API: Fix numeric and date based filters#15286elit0451 merged 2 commits intorelease/13.0from
elit0451 merged 2 commits intorelease/13.0from
Conversation
elit0451
approved these changes
Nov 27, 2023
Contributor
elit0451
left a comment
elit0451
left a comment
There was a problem hiding this comment.
💪 💪 Great find, merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
As-is, Delivery API filters do not work with numeric or date field types. This PR fixes it.
To keep things a little more manageable I have moved the generation of selector, filter and sort operations to their own separate classes. In the future we might make those replaceable via DI, but for the time being we'll consider them internal implementation details for the Examine based query provider.
Testing this PR
To test this you'll need two filters that query numeric and date field types respectively... and to have these field types in the index, you'll need to create indexers to match.
Or maybe just reach out to @kjac for a demo 😃